Console does not use os.EOL

[imyller]

console.log and console.dir use hardcoded \n for end-of-line instead of platform specific EOL defined in os library.

lib/console.js:

this._stdout.write(util.format.apply(this, arguments) + '\n');

lib/os.js:

exports.EOL = isWindows ? '\r\n' : '\n';

[Fishrock123]

@imyller what sort of impact does this have, if I may ask?

[estliberitas]

@Fishrock123 To me, the only impact is a lack of compliance with Windows line-ending in cmd.exe or so, hah. It seems I must close that PR, thus it produces a bit of complexity, for example, if parsing output in some cross-platform tool. I.e. it would require developer to use os.EOL instead of simple \n.

[silverwind]

I'm not sure this is worth breaking parsing apps over, cmd does render \n-terminated lines fine.

[estliberitas]

Ok, so I'm gonna close that freaky PR

[silverwind]

Let's wait a bit, this needs more discussion.

[imyller]

@Fishrock123 I noticed this minor inconsistency when working with unrelated PR for lib/console.js and opened this issue just to discuss if it would be more proper to use os.EOL; especially when it is documented for end users to be the appropriate line-ending.

os.EOL
A constant defining the appropriate End-of-line marker for the operating system.

Technically hardcoded \n seems to be working solution for all platforms, as @silverwind pointed out.

The question that remains is that if users are guided into using os.EOL shouldn't the Node library itself also prefer to use it?

[luanmuniz]

The question that remains is that if users are guided into using os.EOL shouldn't the Node library itself also prefer to use it?

I think it should. Consistency is always a good thing

I'm not sure this is worth breaking parsing apps over, cmd does render \n-terminated lines fine.

I don't know the extend of this problem and this deserve attention. But i think the parsing apps
should not use hard-coded chars.

[domenic]

I don't see the benefit of this. Are there programs that are breaking due to the lack of \r?

(Personally, as a die-hard Windows user, I hate \r with a passion and banish it from all my projects and environments.)

[imyller]

@domenic To my knowledge, no programs are breaking. This issue was meant to open discussion about internal consistency within a core library regarding the use of os.EOL; or lack of it. I think "feature request" tag given to this issue is unnecessary at this time.

The question about to \ror not to \r only comes from the fact that os.EOL implementation is very simplistic only differentiating Windows from non-Windows; leaving out all other possible options. For example some versions of QNX OS have different EOL than Windows and *nix.

More importantly and generally speaking usage of os.EOL without need to consider its runtime value should be the appropriate and portable way for everyone to use; as it is documented in Node.js.

However, if in this context hard-coded \n is enough and the proper EOL to use inside core library, then we can close this question and move on. I'm perfectly happy with that outcome too.

[sindresorhus]

👎 This would break all the things without much gain. From experience, many modules on npm depends on console.log outputting \n, mine included.

[imyller]

Asked and answered. Hopefully \n is universal enough in the future.

Thank you. Closing the issue.