deps: update v8 to 4.5.103 #2183
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unicode-decoder: fix out-of-band write in utf16 (v8 issue 4274). Include Harmony Array/TypedArray methods unconditionally (Chromium issue 504629).
Member
|
Rubber-stamp LGTM. Can you run the CI before merging? |
Contributor
Author
Contributor
Author
|
Second CI https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/154/ because the first one hit machine issues. TLS failures on win2008 look unrelated and are failing on other CIs too. I will land this tomorrow. |
ofrobots
added a commit
that referenced
this pull request
Jul 16, 2015
unicode-decoder: fix out-of-band write in utf16 (v8 issue 4274). Include Harmony Array/TypedArray methods unconditionally (Chromium issue 504629). PR-URL: #2183 Reviewed-By: Ben Noordhuis <[email protected]>
Contributor
|
@ofrobots did you land this? |
Contributor
Author
|
Yes, landed in a6b6295. |
Member
|
Just in case: this technically is a SEMVER-MAJOR due to backwards incompatible changes in v8 (finally enforcing TDZ in See #2203. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for next+1. This picks up the fix for the out-of-band write unicode-decoder issue.
R=@bnoordhuis?