test: fix test-http2-multiheaders-raw #27885
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryzokuken
approved these changes
May 26, 2019
Contributor
ryzokuken
left a comment
ryzokuken
left a comment
There was a problem hiding this comment.
LGTM. Please respond w/ 👍 to approve fast tracking.
ryzokuken
added
the
code-and-learn
addaleax
approved these changes
May 26, 2019
antsmartian
approved these changes
May 26, 2019
BridgeAR
approved these changes
May 26, 2019
cjihrig
approved these changes
May 26, 2019
Trott
approved these changes
May 27, 2019
Trott
added
fast-track
Collaborator
gireeshpunathil
approved these changes
May 27, 2019
Collaborator
ChALkeR
approved these changes
May 27, 2019
ChALkeR
pushed a commit
that referenced
this pull request
May 27, 2019
Arguments of deepStrictEqual were in incorrect order. Swap first argument (actual value) with the second one (expected value) to make the order correct. PR-URL: #27885 Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Member
|
Landed in 2e9cd82. Thanks for the contribution! 🎉 |
targos
pushed a commit
that referenced
this pull request
May 28, 2019
Arguments of deepStrictEqual were in incorrect order. Swap first argument (actual value) with the second one (expected value) to make the order correct. PR-URL: #27885 Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arguments of deepStrictEqual were in incorrect order. Swap
first argument (actual value) with the second one (expected
value) to make the order correct.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes