test: skip pseudo-tty tests on AIX #28541
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
test
Collaborator
mhdawson
approved these changes
Jul 4, 2019
Member
mhdawson
left a comment
mhdawson
left a comment
There was a problem hiding this comment.
LGTM, we need to get builds back to green and we'll work to re-enable once we have a solution.
Member
|
I'd like to suggest fast tracking this. |
richardlau
approved these changes
Jul 4, 2019
Contributor
Author
|
Landed in 8619b19 |
sam-github
added a commit
that referenced
this pull request
Jul 4, 2019
See: nodejs/build#1820 PR-URL: #28541 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Richard Lau <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 20, 2019
See: nodejs/build#1820 PR-URL: #28541 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Richard Lau <[email protected]>
This was referenced Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: nodejs/build#1820
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes