fs.watch throws exception when recursive is used in incompatible platform#29947

Closed

exx8 wants to merge 15 commits intonodejs:masterfrom

exx8:recursive_err

Commits on Jan 24, 2020

fs: watch signals for recursive incompatibility

Eran Levin
authored and
Trott
committed
Some lints to the fs.js file.

Eran Levin
authored and
Trott
committed
A new error ERR_OPTION_INCOMPATIBLE_WITH_PLATFORM is added to node.

Eran Levin
authored and
Trott
committed
update the relevant test: if on win or osx no exception should be thrown. Otherwise, the new error should be thrown.

Eran Levin
authored and
Trott
committed
Documenting the new changes:

Eran Levin
authored and
Trott
committed
A style change

authored and
Trott
committed
fix according to review

Eran Levin
authored and
Trott
committed
fix to documentation

Eran Levin
authored and
Trott
committed
Update doc/api/fs.md

authored and
Trott
committed
Update doc/api/fs.md

authored and
Trott
committed
Update lib/internal/errors.js

authored and
Trott
committed
reformatting the error definition, and refactor the test

Eran Levin
authored and
Trott
committed
updating test.

Eran Levin
authored and
Trott
committed
fixup! updating test.
Trott
committed
fixup! fixup! updating test.
Trott
committed