Doc: Align the EventTarget.dispatchEvent doc with the actual behavior #39127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
doc
aduh95
reviewed
Jun 23, 2021
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
Thanks, looking good. A few suggestions:
Contributor
Author
|
@aduh95 I have made the changes you suggested. Please take a look at it and let me know if this needs any changes. |
aduh95
approved these changes
Jun 23, 2021
Contributor
|
@nodejs/events @jasnell FYI. |
benjamingr
approved these changes
Jun 24, 2021
Member
benjamingr
left a comment
benjamingr
left a comment
There was a problem hiding this comment.
Yeah this is leftovers from the NodeEventTarget split - good catch and fix!
lpinca
approved these changes
Jun 24, 2021
aduh95
added
the
author ready
PR-URL: nodejs#39127 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Contributor
|
Landed in ffda9a8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39125
Hi @aduh95 @aral @Ayase-252, how does this look?
Let me know if this needs any changes.
Thanks