build: add action to close stale feature requests #41981
Conversation
Implement the prodecure outlined in https://github.com/nodejs/node/blob/master/doc/contributing/feature-request-management.md Signed-off-by: Michael Dawson <[email protected]>
|
Review requested:
|
nodejs-github-bot
added
the
meta
| only-labels: feature request | ||
| exempt-pr-labels: never-stale | ||
| # max requests it will send per run to the GitHub API before it deliberately exits to avoid hitting API rate limits | ||
| operations-per-run: 1 |
There was a problem hiding this comment.
I've set this to 1 so that it only processes 1 per day to start so that we can verify it's working as expected before a larger number of feature requests get tagged.
If there is a better way to test this please let me know. Otherwise the plan would to see it run a few days to make sure it operates as expected and then ramp up to a larger number. Probably still lower than the max (maybe 10 per day) to avoid a flood of stale feature requests all at the same time.
@phillipj I see you added a similar one to close stalled issues. If you have any suggestions/recommendations for testing/roll out they would be greatly appreciated.
There was a problem hiding this comment.
@Mesteery would you suggest the debug-only option as the best way to test out. Looking for any experience/suggestions based on how we tested in the past.
There was a problem hiding this comment.
would you suggest the debug-only option as the best way to test out
No, it was just to inform. Personally, I find operations-per-run a good way to test out.
Co-authored-by: Mestery <[email protected]>
Co-authored-by: Rich Trott <[email protected]>
Co-authored-by: Rich Trott <[email protected]>
Co-authored-by: Rich Trott <[email protected]>
Co-authored-by: Rich Trott <[email protected]>
Co-authored-by: Rich Trott <[email protected]>
Co-authored-by: Rich Trott <[email protected]>
Co-authored-by: Mestery <[email protected]>
Co-authored-by: Antoine du Hamel <[email protected]>
Co-authored-by: Mestery <[email protected]>
|
I'm going to land since I've either addressed or responded to all of the comments and that will let us start to see it in action. I'll have to do at least one more update to move it from doing 1 a day to more later so I can incorporate any other needed changes into that. |
|
Landed in 3fbc10d |
6 participants
Implement the prodecure outlined in
https://github.com/nodejs/node/blob/master/doc/contributing/feature-request-management.md
Signed-off-by: Michael Dawson [email protected]