esm: remove `globalPreload` hook (superseded by `initialize`)#49144

Merged

nodejs-github-bot merged 21 commits intonodejs:mainfrom

JakobJingleheimer:feat/esm-remove-globalpreload

Sep 10, 2023

Commits on Sep 10, 2023

esm: remove `globalPreload` hook (superseded by `initialize`)

JakobJingleheimer
authored and
GeoffreyBooth
committed
remove 'preload' execution

JakobJingleheimer
authored and
GeoffreyBooth
committed
update ESM doc (remove `globalPreload` section

JakobJingleheimer
authored and
GeoffreyBooth
committed
suppress warnings in test cases

JakobJingleheimer
authored and
GeoffreyBooth
committed
remove unused deps

JakobJingleheimer
authored and
GeoffreyBooth
committed
!includes → doesNotMatch

JakobJingleheimer
authored and
GeoffreyBooth
committed
simplify `initializeHooks` return `{ hooks }` → `hooks`

JakobJingleheimer
authored and
GeoffreyBooth
committed
WIP: exposed error? (need to remove catches, debugs, etc)

JakobJingleheimer
authored and
GeoffreyBooth
committed
WIP

JakobJingleheimer
authored and
GeoffreyBooth
committed
remove `writeFileSync` debugging

JakobJingleheimer
authored and
GeoffreyBooth
committed
Delete test that only tests side effects of globalPreload
GeoffreyBooth
committed
Change warning type
GeoffreyBooth
committed
Lint, cleanup
GeoffreyBooth
committed
Restore refactored hook-resolve-type test
GeoffreyBooth
committed
Lint
GeoffreyBooth
committed
Apply suggestion from code review

aduh95
authored and
GeoffreyBooth
committed
lint

aduh95
authored and
GeoffreyBooth
committed
Update lib/internal/modules/esm/hooks.js
GeoffreyBooth
committed
Update lib/internal/modules/esm/hooks.js

aduh95
authored and
GeoffreyBooth
committed
Fixup
GeoffreyBooth
committed
Remove isolated file
GeoffreyBooth
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

esm: remove `globalPreload` hook (superseded by `initialize`)#49144

esm: remove `globalPreload` hook (superseded by `initialize`)#49144
nodejs-github-bot merged 21 commits intonodejs:mainfrom
JakobJingleheimer:feat/esm-remove-globalpreload

Commits on Sep 10, 2023

esm: remove `globalPreload` hook (superseded by `initialize`)

remove 'preload' execution

update ESM doc (remove `globalPreload` section

suppress warnings in test cases

remove unused deps

!includes → doesNotMatch

simplify `initializeHooks` return `{ hooks }` → `hooks`

WIP: exposed error? (need to remove catches, debugs, etc)

WIP

remove `writeFileSync` debugging

Delete test that only tests side effects of globalPreload

Change warning type

Lint, cleanup

Restore refactored hook-resolve-type test

Lint

Apply suggestion from code review

lint

Update lib/internal/modules/esm/hooks.js

Update lib/internal/modules/esm/hooks.js

Fixup

Remove isolated file

Uh oh!

esm: remove `globalPreload` hook (superseded by `initialize`)#49144nodejs-github-bot merged 21 commits intonodejs:mainnodejs/node:mainfrom JakobJingleheimer:feat/esm-remove-globalpreloadJakobJingleheimer/node:feat/esm-remove-globalpreloadCopy head branch name to clipboard

Commits

Commits on Sep 10, 2023

esm: remove `globalPreload` hook (superseded by `initialize`)#49144
nodejs-github-bot merged 21 commits intonodejs:mainfrom
JakobJingleheimer:feat/esm-remove-globalpreload