Skip to content

test: fix flaky timeout in test-pipe-file-to-http #53595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jakecastelli wants to merge 2 commits into from
Closed

test: fix flaky timeout in test-pipe-file-to-http #53595

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b249cb
test: fix flaky timeout
jakecastelli Jun 7, 2024
4bcfdf4
fixup! remove platformTimeout
jakecastelli Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/common/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,9 +264,9 @@ function childShouldThrowAndAbort() {
});
}

function createZeroFilledFile(filename) {
function createZeroFilledFile(filename, size = 10 * 1024 * 1024) {
const fd = fs.openSync(filename, 'w');
fs.ftruncateSync(fd, 10 * 1024 * 1024);
fs.ftruncateSync(fd, size);
fs.closeSync(fd);
}

Expand Down
13 changes: 5 additions & 8 deletions test/parallel/test-pipe-file-to-http.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,16 @@ const tmpdir = require('../common/tmpdir');
tmpdir.refresh();

const filename = tmpdir.resolve('big');
const fileSize = 5 * 1024 * 1024;
let count = 0;

const server = http.createServer((req, res) => {
let timeoutId;
assert.strictEqual(req.method, 'POST');
req.pause();

setTimeout(() => {
const timeoutId = setTimeout(() => {
req.resume();
}, 1000);
}, common.platformTimeout(1000));

req.on('data', (chunk) => {
count += chunk.length;
Expand All @@ -55,7 +55,7 @@ const server = http.createServer((req, res) => {
server.listen(0);

server.on('listening', () => {
common.createZeroFilledFile(filename);
common.createZeroFilledFile(filename, fileSize);
makeRequest();
});

Expand All @@ -73,11 +73,8 @@ function makeRequest() {
req.on('response', (res) => {
res.resume();
res.on('end', () => {
assert.strictEqual(count, fileSize);
server.close();
});
});
}

process.on('exit', () => {
assert.strictEqual(count, 1024 * 10240);
});