Skip to content

cli: mark --conditions flag as stable #54209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aduh95 merged 2 commits into from
Sep 6, 2024
Merged

cli: mark --conditions flag as stable #54209

aduh95 merged 2 commits into from
Sep 6, 2024

Conversation

@guybedford
Copy link
Contributor

@guybedford guybedford commented Aug 4, 2024

This marks the --conditions|-C flag as stable in the docs.

@guybedford
Copy link
Contributor Author

guybedford commented Aug 4, 2024

//cc @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels Aug 4, 2024
@avivkeller avivkeller added experimental Issues and PRs related to experimental features. loaders Issues and PRs related to ES module loaders labels Aug 26, 2024
aduh95
aduh95 reviewed Aug 26, 2024
View reviewed changes
@guybedford @aduh95
Update doc/api/cli.md
e6499b8 
Co-authored-by: Antoine du Hamel <[email protected]>
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 27, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 27, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 27, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/61570/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 29, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/61620/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 29, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/61637/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 6, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/62085/

@aduh95 aduh95 merged commit c813de4 into nodejs:main Sep 6, 2024
@aduh95
Copy link
Contributor

aduh95 commented Sep 6, 2024

Landed in c813de4

@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
Merged
@targos targos mentioned this pull request Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 left review comments

@jasnell jasnell jasnell approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. experimental Issues and PRs related to experimental features. loaders Issues and PRs related to ES module loaders

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@guybedford @nodejs-github-bot @aduh95 @jasnell @avivkeller