Skip to content

Conversation

@panva
Copy link
Member

@panva panva commented Dec 5, 2024

Ed25519 and X25519 algorithms are no longer experimental. They were merged into the main spec.


notable-change PRs with changes that should be highlighted in changelogs.

Following the merge of Curve25519 into the Web Cryptography API Editor's Draft the Ed25519 and X25519 algorithm identifiers are now stable and will no longer emit an ExperimentalWarning upon use.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Dec 5, 2024
@panva panva force-pushed the webcrypto-stable-curve25519 branch 2 times, most recently from f3cf741 to 6ab68a9 Compare December 5, 2024 11:06
@panva panva changed the title crypto: WebCryptoAPI Ed25519 and X25519 algorithms are now stable crypto: graduate WebCryptoAPI Ed25519 and X25519 algorithms as stable Dec 5, 2024
@panva panva force-pushed the webcrypto-stable-curve25519 branch from 6ab68a9 to ba640d8 Compare December 5, 2024 11:10
@panva panva added the webcrypto label Dec 5, 2024
@panva panva marked this pull request as ready for review December 5, 2024 11:10
@panva panva added the web-standards Issues and PRs related to Web APIs label Dec 5, 2024
@panva
Copy link
Member Author

panva commented Dec 5, 2024

cc @nodejs/web-standards

@codecov
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.99%. Comparing base (3c2da4b) to head (ba640d8).
Report is 1363 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #56142   +/-   ##
=======================================
  Coverage   87.99%   87.99%           
=======================================
  Files         656      656           
  Lines      188999   188995    -4     
  Branches    35981    35985    +4     
=======================================
  Hits       166301   166301           
+ Misses      15865    15861    -4     
  Partials     6833     6833           
Files with missing lines Coverage Δ
lib/internal/crypto/util.js 93.05% <100.00%> (-0.05%) ⬇️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2024
@nodejs-github-bot

This comment was marked as outdated.

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 5, 2024
@richardlau richardlau added the notable-change PRs with changes that should be highlighted in changelogs. label Dec 5, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @richardlau.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

@panva
Copy link
Member Author

panva commented Dec 5, 2024

notable-change PRs with changes that should be highlighted in changelogs.

Following the merge of Curve25519 into the Web Cryptography API Editor's Draft the Ed25519 and X25519 algorithm identifiers are now stable and will no longer emit an ExperimentalWarning upon use.

@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🚀

@nodejs-github-bot
Copy link
Collaborator

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 6, 2024
@aduh95
Copy link
Contributor

aduh95 commented Dec 7, 2024

The subsystem should be doc: since it's only touching documentation. And since it's doc-only, we should also backport this to 20.x and 18.x, right? EDIT: looks like I misread the changes, it does touch lib/. Anyway, should we backport this to maintenance release lines?

@phvzxsqe

This comment was marked as off-topic.

ThiH69

This comment was marked as off-topic.

@aduh95 aduh95 removed commit-queue Add this label to land a pull request using GitHub Actions. lts-watch-v22.x PRs that may need to be released in v22.x labels Feb 3, 2025
@marco-ippolito marco-ippolito added backported-to-v20.x PRs backported to the v20.x-staging branch. and removed lts-watch-v20.x PRs that may need to be released in v20.x labels Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backported-to-v20.x PRs backported to the v20.x-staging branch. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs. web-standards Issues and PRs related to Web APIs webcrypto

Projects

None yet

Development

Successfully merging this pull request may close these issues.