Skip to content

src: move instead of copy shared pointer in node_blob #57120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Feb 20, 2025
Merged

src: move instead of copy shared pointer in node_blob #57120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/node_blob.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ void Blob::New(const FunctionCallbackInfo<Value>& args) {
return nullptr;
}
return DataQueue::CreateInMemoryEntryFromBackingStore(
store, byte_offset, byte_length);
std::move(store), byte_offset, byte_length);
}

// If the ArrayBuffer is not detachable, we will copy from it instead.
Expand All @@ -216,7 +216,7 @@ void Blob::New(const FunctionCallbackInfo<Value>& args) {
uint8_t* ptr = static_cast<uint8_t*>(buf->Data()) + byte_offset;
std::copy(ptr, ptr + byte_length, static_cast<uint8_t*>(store->Data()));
return DataQueue::CreateInMemoryEntryFromBackingStore(
store, 0, byte_length);
std::move(store), 0, byte_length);
};

// Every entry should be either an ArrayBuffer, ArrayBufferView, or Blob.
Expand Down
Loading