Skip to content

deps: brotli: cherry-pick e230f474b87 fix LoongArch64 architecture build failed #61003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Dec 11, 2025
Merged

deps: brotli: cherry-pick e230f474b87 fix LoongArch64 architecture build failed #61003

nodejs-github-bot merged 1 commit into from
Dec 11, 2025

Conversation

@Javonne-liu
Copy link
Contributor

@Javonne-liu Javonne-liu commented Dec 9, 2025

issue:#60835
LoongArch64 CI is in a failed state (https://ci.nodejs.org/job/node-test-commit-loongarch64/nodes=clfs23-64/852)

After upgrading Brotli to 1.2.0, the LoongArch64 architecture compilation fails with the error "invalid argument of ‘model’ attribute".

../deps/brotli/c/common/constants.h:196:23: error: invalid argument of ‘model’ attribute
  196 | BrotliPrefixCodeRange _kBrotliPrefixCodeRanges[BROTLI_NUM_BLOCK_LEN_SYMBOLS];
      |                       ^~~~~~~~~~~~~~~~~~~~~~~~
../deps/brotli/c/common/constants.c:10:23: error: invalid argument of ‘model’ attribute
   10 | BrotliPrefixCodeRange _kBrotliPrefixCodeRanges[BROTLI_NUM_BLOCK_LEN_SYMBOLS] = {
      |                       ^~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [deps/brotli/brotli.target.mk:122：/home/iojs/build/workspace/node-test-commit-loongarch64/out/Release/obj.target/brotli/deps/brotli/c/common/constants.o] 错误 1
make[2]: *** 正在等待未完成的任务....

Origin commit message:

disable BROTLI_MODEL macro for some targets

PiperOrigin-RevId: 827486322

Refs: google/brotli@e230f47

@Javonne-liu
deps: brotli: cherry-pick e230f474b87
be83b40 
Origin commit message:

	disable BROTLI_MODEL macro for some targets

	PiperOrigin-RevId: 827486322

Refs: google/brotli@e230f47
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 9, 2025

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added brotli Issues and PRs related to the brotli dependency. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Dec 9, 2025
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 10, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 10, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 10, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70474/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 10, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70485/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 10, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 11, 2025
@nodejs-github-bot nodejs-github-bot merged commit 180c717 into nodejs:main Dec 11, 2025
75 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 11, 2025

Landed in 180c717

aduh95 pushed a commit that referenced this pull request Jan 9, 2026
@Javonne-liu @aduh95
deps: brotli: cherry-pick e230f474b87
54ee75a 
Origin commit message:

	disable BROTLI_MODEL macro for some targets

	PiperOrigin-RevId: 827486322

Refs: google/brotli@e230f47
PR-URL: #61003
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
aduh95 pushed a commit that referenced this pull request Jan 12, 2026
@Javonne-liu @aduh95
deps: brotli: cherry-pick e230f474b87
cbd0c91 
Origin commit message:

	disable BROTLI_MODEL macro for some targets

	PiperOrigin-RevId: 827486322

Refs: google/brotli@e230f47
PR-URL: #61003
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jan 13, 2026
@Javonne-liu @RafaelGSS
deps: brotli: cherry-pick e230f474b87
d2e6dff 
Origin commit message:

	disable BROTLI_MODEL macro for some targets

	PiperOrigin-RevId: 827486322

Refs: google/brotli@e230f47
PR-URL: #61003
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@github-actions github-actions bot mentioned this pull request Jan 16, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. brotli Issues and PRs related to the brotli dependency. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Javonne-liu @nodejs-github-bot @cjihrig @marco-ippolito @aduh95