Open
Conversation
KhafraDev
requested changes
Nov 28, 2025
Member
KhafraDev
left a comment
There was a problem hiding this comment.
My comment in the original issue makes it seem like this is not an issue in undici.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4678 +/- ##
==========================================
- Coverage 92.86% 92.85% -0.02%
==========================================
Files 107 107
Lines 33499 33517 +18
==========================================
+ Hits 31108 31121 +13
- Misses 2391 2396 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
It's undici that is the problem, not node. Once the parent signal is garbage collected, the child loses its reference and therefore cannot propagate the abort signal, even if the original signal is aborted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to #4068
Changes
This PR fixes an issue where cloning a
Requestcaused the cloned instance to lose itsAbortSignalbehavior under certain GC conditions.The underlying problem was that the
signalreference could be garbage-collected prematurely, preventing the abort event from propagating to the cloned request. This resulted in inconsistent abort behavior on the very first request processed after a clone.The fix ensures the
signaland its abort listener remain properly retained across clones, restoring consistent abort propagation for clonedRequestobjects.Bug Fixes
Request.clone()ornew Request(request), could drop the associatedAbortSignallistener during garbage collection.Requestobjects consistently propagate abort events, including during the initial request lifecycle.Status