Replace secrets with credentials so /admin is accessible#672
Open
rianrainey wants to merge 1 commit intonodunayo:masterfrom
Open
Replace secrets with credentials so /admin is accessible#672rianrainey wants to merge 1 commit intonodunayo:masterfrom
rianrainey wants to merge 1 commit intonodunayo:masterfrom
Conversation
rianrainey
commented
Jul 10, 2025
| /coverage/* | ||
|
|
||
| /config/credentials/development.key | ||
| /config/credentials/test.key |
Author
There was a problem hiding this comment.
Should add production.key here when that's ready.
Owner
|
Okay, great. Thank you! Will take a look soon! |
Owner
|
Hi @rianrainey! Turns out we've started this work as part of #586 so I'll likely just continue it from there and close this issue. Thank you for you work on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replace Rails secrets with Rails credentials.
Why was this work done? Is there a related Issue?
Fixes #671
Where should a reviewer start?
Try to spin up the app fresh on the main branch and visit
/admin. You should get the error screenshot attached below. In Rails 7.2, secrets functionality was dropped. This PR brings the app up to date with Rails 8 best practices, removes dependency ondotenv-rails, and secrets file.For more info: https://guides.rubyonrails.org/security.html#custom-credentials
Are there any manual testing steps?
I think this PR still needs a Production credential file to be created. You can use development or test as a guide. I didn't know those creds so I'll leave that to you.
Screenshots
Before
After
Deployment instructions
Database changes
New ENV variables