Dual stack IPv6 support for external CNIs and fakeipam #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Levovar
reviewed
Apr 12, 2019
Collaborator
|
overall, looks good |
Collaborator
|
LGTM, once you are satisfied with it I can merge |
Collaborator
|
I merged my UT branch if you don't mind, case it will be easier to rebase this on top of mine, than via-versa. |
TothFerenc
changed the title
Contributor
Author
|
Tested with macvlan CNI inside a VM:
So this PR is ready to merge. |
Added new MACVLAN based TC to cover dual-stack case. Fixed a small bug in the schema: IPs need the "omitempty" JSON deisgnation for proper marshalling / unmarshalling.
Collaborator
|
UTs corrected, new code functionally covered, so everything looks to be in tip top shape :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
What does this PR give to us:
Add Dual stack IPv6 support for external CNIs and fakeipam.
Which issue(s) this PR fixes
Fixes #73
Special notes for your reviewer:
It is under testing, but please review it whether this PR is conceptually ok.
Does this PR introduce a user-facing change?:
NONE