fix(types): Add autoScroll to thumbs.update type signature#8146
Merged
nolimits4web merged 2 commits intonolimits4web:masterfrom Jan 28, 2026
Merged
fix(types): Add autoScroll to thumbs.update type signature#8146nolimits4web merged 2 commits intonolimits4web:masterfrom
autoScroll to thumbs.update type signature#8146nolimits4web merged 2 commits intonolimits4web:masterfrom
Conversation
to support adding more parameters in the future.
`autoScroll` will be `true` by default when `p` is `undefined` or `{}`
Owner
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #8141
update()supports 2 parameters:swiper/src/modules/thumbs/thumbs.mjs
Line 96 in 9752771
update()is exposed publicly inswiper.thumbs.update.In this PR:
Add
p: { autoScroll: boolean }toupdate()'s type signature.When calling
update(false, { otherOption: true }), defaultautoScrolltotrue