feat(lyrics-review): Add Replace Segment Lyrics mode#389
Merged
Conversation
Add a third mode to the Edit All Lyrics modal that lets users swap in custom lyrics line-by-line while preserving existing segment timing. Unlike "Replace All" which loses all timing data, this mode keeps each segment's start/end times and creates new word objects with estimated timing from the segment duration. - Add createWordsWithDistributedTiming shared utility in wordUtils.ts - Refactor EditModal's handleReplaceAllWords to use the shared utility - Add "Replace Segment Lyrics" card in ModeSelectionModal - Add replaceSegments mode with line-count validation in ReplaceAllLyricsModal - Fix Makefile build-frontend to clean stale output before copying - Restore accidentally deleted nextjs_frontend/__init__.py - Add unit tests (wordUtils), component tests, and E2E Playwright tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createWordsWithDistributedTimingshared utility from EditModal for reusebuild-frontendto clean stale output before copying (was causing old JS chunks to persist)nextjs_frontend/__init__.pyTest plan
createWordsWithDistributedTiming(8 cases)karaoke-genCLI@coderabbitai ignore
🤖 Generated with Claude Code