Remove unused using directives of Crmf#125
Open
zwcloud wants to merge 1 commit intonovotnyllc:netstandardfrom
Open
Remove unused using directives of Crmf#125zwcloud wants to merge 1 commit intonovotnyllc:netstandardfrom
zwcloud wants to merge 1 commit intonovotnyllc:netstandardfrom
Conversation
This makes `CertRequest.cs` no longer depends on [/crypto/src/crmf/](https://github.com/novotnyllc/bc-csharp/tree/netstandard/crypto/src/crmf) directory and makes it easy to reduce the size of bc to reduce the built size of final product.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
CertRequest.csno longer depends on /crypto/src/crmf/ directory and makes it easy to reduce the size of bc to reduce the built size of final product.In my case, I only need to parse a CmsSignedData bytes, so many parts of bc should be removed. I found that in this file
using Org.BouncyCastle.Crmf;introduced the dependency to/crypto/src/crmf, and we can remove this using safely because it is not used, which is displayed in gray in the IDE: