Reload types should close the newly opened connection.#3561
Merged
roji merged 2 commits intonpgsql:mainfrom Jun 30, 2025
Merged
Reload types should close the newly opened connection.#3561roji merged 2 commits intonpgsql:mainfrom
roji merged 2 commits intonpgsql:mainfrom
Conversation
roji
requested changes
Jun 30, 2025
Member
roji
left a comment
There was a problem hiding this comment.
Thanks, good catch! There's the same problem just below in the async version, can you please fix that too?
Contributor
Author
Did you end up on the last commit? Both are changed in this PR. Can't see what you are referring to. |
roji
approved these changes
Jun 30, 2025
Member
roji
left a comment
There was a problem hiding this comment.
Ah sorry, I see the second fix now, my bad.
roji
pushed a commit
that referenced
this pull request
Jun 30, 2025
Member
|
Backported to 9.0.5 via 5014ee6 |
This was referenced Nov 24, 2025
Open
Open
This was referenced Dec 22, 2025
This was referenced Feb 9, 2026
Merged
This was referenced Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always close connection after types was reloaded.
Fixes #3560