Skip to content

deps: replace node builtin rmSync with rimraf#412

Merged
wraithgar merged 2 commits intonpm:mainfrom
mbtools:rimraf
Nov 25, 2024
Merged

deps: replace node builtin rmSync with rimraf#412
wraithgar merged 2 commits intonpm:mainfrom
mbtools:rimraf

Conversation

@mbtools
Copy link
Contributor

@mbtools mbtools commented Nov 22, 2024

This avoids the EBUSY issue during "spawn daemon" test mentioned in #408

@wraithgar
Copy link
Member

Add that comment and I'll land this.

Co-authored-by: Gar <wraithgar@github.com>
@wraithgar wraithgar changed the title chore: replace rmSync with rimraf deps: replace node builtin rmSync with rimraf Nov 25, 2024
@wraithgar wraithgar merged commit 47b928c into npm:main Nov 25, 2024
@github-actions github-actions bot mentioned this pull request Nov 25, 2024
@wraithgar
Copy link
Member

This should have been a chore you were right originally, as this was a dev dep.

Ah well.

wraithgar pushed a commit that referenced this pull request Nov 25, 2024
🤖 I have created a release *beep* *boop*
---


## [21.0.0](v20.0.0...v21.0.0)
(2024-11-25)
### ⚠️ BREAKING CHANGES
* `bun.lockb` files are now included in the strict ignore list during
packing
* this module is now compatible with the following node versions:
^20.17.0 || >=22.9.0
### Bug Fixes
*
[`844dc08`](844dc08)
update node engines to ^20.17.0 || >=22.9.0 (#414) (@wraithgar)
### Dependencies
*
[`2cb6fa7`](2cb6fa7)
[#415](#415) `npm-packlist@10.0.0`
(#415)
*
[`47b928c`](47b928c)
[#412](#412) replace node builtin
rmSync with rimraf (#412) (@mbtools)
### Chores
*
[`b6f35a2`](b6f35a2)
[#402](#402) bump @npmcli/arborist
from 7.5.4 to 8.0.0 (#402) (@dependabot[bot])
*
[`1ef54ba`](1ef54ba)
[#408](#408) support tests on win32
(#408) (@mbtools)
*
[`555b000`](555b000)
[#401](#401) bump @npmcli/template-oss
from 4.23.3 to 4.23.4 (#401) (@dependabot[bot], @npm-cli-bot)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
zkat pushed a commit to zkat/pacote that referenced this pull request Apr 1, 2025
🤖 I have created a release *beep* *boop*
---


## [21.0.0](npm/pacote@v20.0.0...v21.0.0)
(2024-11-25)
### ⚠️ BREAKING CHANGES
* `bun.lockb` files are now included in the strict ignore list during
packing
* this module is now compatible with the following node versions:
^20.17.0 || >=22.9.0
### Bug Fixes
*
[`844dc08`](npm@844dc08)
update node engines to ^20.17.0 || >=22.9.0 (npm#414) (@wraithgar)
### Dependencies
*
[`2cb6fa7`](npm@2cb6fa7)
[npm#415](npm#415) `npm-packlist@10.0.0`
(npm#415)
*
[`47b928c`](npm@47b928c)
[npm#412](npm#412) replace node builtin
rmSync with rimraf (npm#412) (@mbtools)
### Chores
*
[`b6f35a2`](npm@b6f35a2)
[npm#402](npm#402) bump @npmcli/arborist
from 7.5.4 to 8.0.0 (npm#402) (@dependabot[bot])
*
[`1ef54ba`](npm@1ef54ba)
[npm#408](npm#408) support tests on win32
(npm#408) (@mbtools)
*
[`555b000`](npm@555b000)
[npm#401](npm#401) bump @npmcli/template-oss
from 4.23.3 to 4.23.4 (npm#401) (@dependabot[bot], @npm-cli-bot)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
zkat pushed a commit to zkat/pacote that referenced this pull request Apr 1, 2025
🤖 I have created a release *beep* *boop*
---


## [21.0.0](npm/pacote@v20.0.0...v21.0.0)
(2024-11-25)
### ⚠️ BREAKING CHANGES
* `bun.lockb` files are now included in the strict ignore list during
packing
* this module is now compatible with the following node versions:
^20.17.0 || >=22.9.0
### Bug Fixes
*
[`844dc08`](npm@844dc08)
update node engines to ^20.17.0 || >=22.9.0 (npm#414) (@wraithgar)
### Dependencies
*
[`2cb6fa7`](npm@2cb6fa7)
[npm#415](npm#415) `npm-packlist@10.0.0`
(npm#415)
*
[`47b928c`](npm@47b928c)
[npm#412](npm#412) replace node builtin
rmSync with rimraf (npm#412) (@mbtools)
### Chores
*
[`b6f35a2`](npm@b6f35a2)
[npm#402](npm#402) bump @npmcli/arborist
from 7.5.4 to 8.0.0 (npm#402) (@dependabot[bot])
*
[`1ef54ba`](npm@1ef54ba)
[npm#408](npm#408) support tests on win32
(npm#408) (@mbtools)
*
[`555b000`](npm@555b000)
[npm#401](npm#401) bump @npmcli/template-oss
from 4.23.3 to 4.23.4 (npm#401) (@dependabot[bot], @npm-cli-bot)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants