Add pagination for finding commitId #201
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When searching the branch for the commitId, use pagination to search more commits
meeroslav
requested changes
Nov 12, 2025
Collaborator
meeroslav
left a comment
meeroslav
left a comment
There was a problem hiding this comment.
The current solution doesn't work.
Can you replace it with a suggested async iterator and build the code so that the PR contains both source and the dist files?
Thanks!
Comment on lines
+260
to
+281
| let commitFound = false; | ||
| yield octokit.paginate("GET /repos/{owner}/{repo}/commits", { | ||
| owner, | ||
| repo, | ||
| sha: branchName, | ||
| per_page: 100, | ||
| }, (response, done) => { | ||
| if (response.data.some((commit: { sha: string }) => commit.sha === commitSha)) { | ||
| commitFound = true; | ||
| done(); // Stop pagination if commit is found | ||
| } | ||
|
|
||
| return commits.data.some( | ||
| (commit: { sha: string }) => commit.sha === commitSha, | ||
| // Decrement maxPages and stop if limit reached | ||
| if (maxPages <= 1) { // Use <= 1 because it's decremented after checking | ||
| done(); | ||
| } | ||
| maxPages--; | ||
| return response; | ||
| } | ||
| ); | ||
|
|
||
| return commitFound; |
Collaborator
There was a problem hiding this comment.
This doesn't work outside of a generator. Can you modify it to use async iterrator instead?
let maxPages = 20; // TODO: This could be made an input param to allow larger/longer searches
for await (const response of octokit.paginate.iterator(
'GET /repos/{owner}/{repo}/commits',
{
owner,
repo,
sha: branchName,
per_page: 100,
},
)) {
if (
response.data.some(
(commit: { sha: string }) => commit.sha === commitSha,
)
) {
return true;
}
maxPages--;
if (maxPages <= 1) {
break;
}
}
return false;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When searching the branch for the commitId, use pagination to search more commits
Fixes #144