chore(core): build nx to local dist and use nodenext by Coly010 · Pull Request #34111 · nrwl/nx

Coly010 · 2026-01-15T14:14:25Z

Current Behavior

The nx package compiles its TypeScript output to ../../dist/packages/nx/ (relative to the package root), which places build artifacts outside the package directory at the repo root level (dist/packages/nx/). This makes the package structure harder to reason about, complicates the build pipeline, and doesn't align with how most packages organize their output.

The package uses "module": "commonjs" with basic module resolution, which limits future migration paths toward ESM.

Expected Behavior

The nx package now builds to a local dist/ directory within the package itself (packages/nx/dist/). This is a cleaner, more standard layout — like having your tools in your own toolbox instead of scattered across the workshop.

Key changes:

Build configuration (packages/nx/tsconfig.lib.json):

outDir changed from ../../dist/packages/nx to dist (local to package)
module changed to nodenext with moduleResolution: nodenext
Updated include patterns to explicitly list source directories

Package entry points (packages/nx/package.json):

bin paths updated: ./bin/nx.js → ./dist/bin/nx.js
Added "type": "commonjs" explicitly
Added comprehensive exports map with @nx/nx-source condition for dev/test resolution back to TS source
Added postinstall path update to ./dist/bin/post-install

Module resolution fixes:

Created src/utils/handle-import.ts — a CJS-first import utility that falls back to ESM import() for ESM-only packages, providing a single migration point for future ESM work
Converted dynamic await import() calls to require(require.resolve()) pattern where needed to satisfy nodenext extension requirements
Plugin worker spawn path now uses correct .ts/.js extension based on runtime context (source vs compiled)

Test infrastructure:

Added custom jest-resolver.js for the nx package that resolves nx/... imports using the @nx/nx-source exports condition, so tests run against TS source
Updated jest.preset.js with SWC transformer configuration
Added chalk mock for test compatibility

CI and tooling:

Conformance check updated to build workspace-plugin first (the Nx Cloud runner lacks @swc-node/register for TS resolution)
Conformance rule paths in nx.json now point to compiled dist/workspace-plugin/src/... output
Added dist to eslint ignore patterns to prevent linting compiled output
Added workspace-plugin build target and updated its dependencies

Other fixes:

Various import path fixes across create-nx-workspace, gradle, and other packages to work with nodenext resolution
Updated e2e test paths to reference the new dist location
Fixed .gitignore and .npmignore for the new output structure

Related Issue(s)

Internal infrastructure improvement — no external issue.

vercel · 2026-01-15T14:14:28Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
nx-dev	Ready	Preview	Jan 23, 2026 5:18pm

netlify · 2026-01-15T14:14:31Z

❌ Deploy Preview for nx-docs failed. Why did it fail? →

Name	Link
🔨 Latest commit	`aa747a3`
🔍 Latest deploy log	https://app.netlify.com/projects/nx-docs/deploys/69bdba436b5600000847c534

nx-cloud · 2026-01-15T14:15:12Z

View your CI Pipeline Execution ↗ for commit aa747a3

Command	Status	Duration	Result
`nx affected --targets=lint,test,build,e2e,e2e-c...`	✅ Succeeded	10m 21s	View ↗
`nx run-many -t check-imports check-lock-files c...`	✅ Succeeded	9s	View ↗
`nx-cloud record -- pnpm nx conformance:check`	✅ Succeeded	7s	View ↗
`nx build workspace-plugin`	✅ Succeeded	56s	View ↗
`nx-cloud record -- nx format:check`	✅ Succeeded	12s	View ↗
`nx-cloud record -- nx sync:check`	✅ Succeeded	<1s	View ↗
`nx affected -t e2e-macos-local --parallel=1 --b...`	✅ Succeeded	1m 1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-03-20 21:37:49 UTC

Co-authored-by: Coly010 <Coly010@users.noreply.github.com>

…esbuild import The react-native vite config template imported esbuild directly, which fails during project graph processing in pnpm strict mode because esbuild is only a transitive dependency of vite and not hoisted to root node_modules. Fixes e2e-detox:e2e-macos-local failure.

When Nx is built to a local dist directory, resolveNx(null) computes the "global root" by going 4 directories up from __dirname, which lands in the wrong location and resolves to a different nx. This causes isLocalInstall to be false, so the bin tries to require itself (cached no-op) and nothing happens. Adding localNx === __filename as a fallback check: if the workspace wants this exact file, we are the local install by definition.

With nodenext module resolution, Node requires explicit file extensions when resolving module paths. The daemon server spawn already uses start.js with the extension, but the plugin worker path was missing it.

The conformance runner can't resolve TS conformance rules without @swc-node/register. Build workspace-plugin to JS first, then point conformance rule paths to the compiled dist output.

Add dist/ to eslint ignore patterns since the new outDir puts compiled output inside packages/nx/dist/. Also add module boundary eslint-disable for jest-resolver.js which needs a relative import.

When running from TS source (tests), use plugin-worker.ts. When running from compiled dist (production), use plugin-worker.js.

nx-cloud

Nx Cloud is proposing a fix for your failed CI:

We updated tools/workspace-plugin/package.json to fix the @nx/dependency-checks lint errors introduced when conformance rules were added to the workspace plugin. The missing packages (@nx/conformance, glob, js-yaml, shiki, semver) are now declared as dependencies, and the unused @nx/eslint entry has been removed. This aligns the declared dependencies with what is actually imported in the conformance rule source files.

Note

⏳ We are verifying this fix by re-running workspace-plugin:lint.

diff --git a/tools/workspace-plugin/package.json b/tools/workspace-plugin/package.json
index a9f9ef81bf..2fd35f48ba 100644
--- a/tools/workspace-plugin/package.json
+++ b/tools/workspace-plugin/package.json
@@ -5,12 +5,16 @@
   "generators": "./generators.json",
   "executors": "./executors.json",
   "dependencies": {
+    "@nx/conformance": "4.0.0",
     "@nx/devkit": "workspace:*",
-    "@nx/eslint": "workspace:*",
     "@nx/plugin": "workspace:*",
     "@nx/js": "workspace:*",
     "@xmldom/xmldom": "^0.8.10",
+    "glob": "7.1.4",
+    "js-yaml": "^4.1.0",
     "nx": "workspace:*",
+    "semver": "catalog:",
+    "shiki": "^4.0.2",
     "tslib": "catalog:typescript"
   },
   "type": "commonjs",

🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.

Or Apply changes locally with:

npx nx-cloud apply-locally lXvn-PtJK

Apply fix locally with your editor ↗ View interactive diff ↗

_{🎓 Learn more about Self-Healing CI on nx.dev}

nx-cloud

Important

At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.

Nx Cloud is proposing a fix for your failed CI:

We updated tools/workspace-plugin/package.json to fix the @nx/dependency-checks lint errors introduced when conformance rules were added to the workspace plugin. The missing packages (@nx/conformance, glob, js-yaml, shiki, semver) are now declared as dependencies, and the unused @nx/eslint entry has been removed. This aligns the declared dependencies with what is actually imported in the conformance rule source files.

Tip

✅ We verified this fix by re-running workspace-plugin:lint.

diff --git a/tools/workspace-plugin/package.json b/tools/workspace-plugin/package.json
index a9f9ef81bf..2fd35f48ba 100644
--- a/tools/workspace-plugin/package.json
+++ b/tools/workspace-plugin/package.json
@@ -5,12 +5,16 @@
   "generators": "./generators.json",
   "executors": "./executors.json",
   "dependencies": {
+    "@nx/conformance": "4.0.0",
     "@nx/devkit": "workspace:*",
-    "@nx/eslint": "workspace:*",
     "@nx/plugin": "workspace:*",
     "@nx/js": "workspace:*",
     "@xmldom/xmldom": "^0.8.10",
+    "glob": "7.1.4",
+    "js-yaml": "^4.1.0",
     "nx": "workspace:*",
+    "semver": "catalog:",
+    "shiki": "^4.0.2",
     "tslib": "catalog:typescript"
   },
   "type": "commonjs",

🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.

Or Apply changes locally with:

npx nx-cloud apply-locally lXvn-PtJK

Apply fix locally with your editor ↗ View interactive diff ↗

_{🎓 Learn more about Self-Healing CI on nx.dev}

Add missing dependencies (conformance, glob, js-yaml, semver, shiki) and remove unused @nx/eslint.

nx-cloud

Nx Cloud is proposing a fix for your failed CI:

We ran nx sync to remove the stale project reference to packages/eslint/tsconfig.lib.json from tools/workspace-plugin/tsconfig.lib.json. This reference became stale as a result of the workspace-plugin dependency changes introduced in this PR. Running nx sync keeps TypeScript project references consistent with the actual project dependency graph.

Note

⏳ We are verifying this fix by re-running nx-cloud record -- nx sync:check.

diff --git a/tools/workspace-plugin/tsconfig.lib.json b/tools/workspace-plugin/tsconfig.lib.json
index 19a65594..c6ce8fb2 100644
--- a/tools/workspace-plugin/tsconfig.lib.json
+++ b/tools/workspace-plugin/tsconfig.lib.json
@@ -26,9 +26,6 @@
     {
       "path": "../../packages/plugin/tsconfig.lib.json"
     },
-    {
-      "path": "../../packages/eslint/tsconfig.lib.json"
-    },
     {
       "path": "../../packages/devkit/tsconfig.lib.json"
     }

🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.

Or Apply changes locally with:

npx nx-cloud apply-locally L6fs-qRIq

Apply fix locally with your editor ↗ View interactive diff ↗

_{🎓 Learn more about Self-Healing CI on nx.dev}

nx-cloud

Nx Cloud is proposing a fix for your failed CI:

We ran nx sync to remove the stale project reference to packages/eslint/tsconfig.lib.json from tools/workspace-plugin/tsconfig.lib.json. This reference became stale as a result of the workspace-plugin dependency changes introduced in this PR. Running nx sync keeps TypeScript project references consistent with the actual project dependency graph.

Tip

✅ We verified this fix by re-running nx-cloud record -- nx sync:check.

diff --git a/tools/workspace-plugin/tsconfig.lib.json b/tools/workspace-plugin/tsconfig.lib.json
index 19a65594..c6ce8fb2 100644
--- a/tools/workspace-plugin/tsconfig.lib.json
+++ b/tools/workspace-plugin/tsconfig.lib.json
@@ -26,9 +26,6 @@
     {
       "path": "../../packages/plugin/tsconfig.lib.json"
     },
-    {
-      "path": "../../packages/eslint/tsconfig.lib.json"
-    },
     {
       "path": "../../packages/devkit/tsconfig.lib.json"
     }

🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.

Or Apply changes locally with:

npx nx-cloud apply-locally L6fs-qRIq

Apply fix locally with your editor ↗ View interactive diff ↗

_{🎓 Learn more about Self-Healing CI on nx.dev}

Co-authored-by: Coly010 <Coly010@users.noreply.github.com>

nx-cloud

✅ The fix from Nx Cloud was applied automatically

We ran nx sync to remove the stale project reference to packages/eslint/tsconfig.lib.json from tools/workspace-plugin/tsconfig.lib.json. This reference became stale as a result of the workspace-plugin dependency changes introduced in this PR. Running nx sync keeps TypeScript project references consistent with the actual project dependency graph.

Tip

✅ We verified this fix by re-running nx-cloud record -- nx sync:check.

Suggested Fix changes

diff --git a/tools/workspace-plugin/tsconfig.lib.json b/tools/workspace-plugin/tsconfig.lib.json
index 19a65594..c6ce8fb2 100644
--- a/tools/workspace-plugin/tsconfig.lib.json
+++ b/tools/workspace-plugin/tsconfig.lib.json
@@ -26,9 +26,6 @@
     {
       "path": "../../packages/plugin/tsconfig.lib.json"
     },
-    {
-      "path": "../../packages/eslint/tsconfig.lib.json"
-    },
     {
       "path": "../../packages/devkit/tsconfig.lib.json"
     }

🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.

View interactive diff ↗

_{🎓 Learn more about Self-Healing CI on nx.dev}

github-actions · 2026-03-26T00:18:55Z

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

Coly010 self-assigned this Jan 15, 2026

vercel bot deployed to Preview January 15, 2026 14:21 View deployment

This comment was marked as outdated.

Sign in to view

Coly010 force-pushed the chore/nx-local-dist branch from 1845ef4 to e88f09d Compare January 15, 2026 15:15

vercel bot deployed to Preview January 15, 2026 15:22 View deployment

This comment was marked as outdated.

Sign in to view

Coly010 force-pushed the chore/nx-local-dist branch from e88f09d to 355cb3c Compare January 15, 2026 16:38

vercel bot deployed to Preview January 15, 2026 16:48 View deployment

Coly010 changed the title ~~chore(core): build nx to local dist and use nodenext"~~ chore(core): build nx to local dist and use nodenext Jan 15, 2026

vercel bot deployed to Preview January 15, 2026 17:06 View deployment

Coly010 force-pushed the chore/nx-local-dist branch from 0e73eba to 3038774 Compare January 15, 2026 17:55

vercel bot deployed to Preview January 15, 2026 18:00 View deployment

Coly010 force-pushed the chore/nx-local-dist branch from 3038774 to bce8591 Compare January 15, 2026 18:03

vercel bot deployed to Preview January 15, 2026 18:09 View deployment

This comment was marked as outdated.

Sign in to view

Coly010 force-pushed the chore/nx-local-dist branch from bce8591 to 4b4f86a Compare January 21, 2026 13:53

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview January 21, 2026 14:07 View deployment

Coly010 force-pushed the chore/nx-local-dist branch from 0defccd to 8db4c8c Compare January 21, 2026 15:02

vercel bot deployed to Preview January 21, 2026 15:06 View deployment

vercel bot deployed to Preview January 21, 2026 15:23 View deployment

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview January 21, 2026 16:55 View deployment

vercel bot deployed to Preview January 21, 2026 18:08 View deployment

vercel bot deployed to Preview January 22, 2026 10:48 View deployment

Coly010 force-pushed the chore/nx-local-dist branch from 4304d08 to ecfcaec Compare January 22, 2026 12:16

vercel bot deployed to Preview January 22, 2026 12:23 View deployment

Coly010 and others added 17 commits March 20, 2026 12:13

chore(core): ensure versions are found correctly

66820dd

chore(core): fix import

45aa0c8

chore(core): fix astro docs build

9e845ef

chore(core): address comments

8c35384

chore(core): update gitignore

b25f7c4

chore(core): fix exports

6c79c85

fix(core): use default import for parse-markdown-links

8ca8764

Co-authored-by: Coly010 <Coly010@users.noreply.github.com>

=chore(core): redeploy netlify

734d0fd

chore(core): fix project-graph import

450055c

chore(core): ignore the temp vite files

f077b6a

chore(core): add conformance check to CI and update lockfile

6393e4b

fix(core): add .js extension to plugin-worker spawn path

6ac878f

With nodenext module resolution, Node requires explicit file extensions when resolving module paths. The daemon server spawn already uses start.js with the extension, but the plugin worker path was missing it.

fix(core): build workspace-plugin before conformance check in CI

e8388ae

The conformance runner can't resolve TS conformance rules without @swc-node/register. Build workspace-plugin to JS first, then point conformance rule paths to the compiled dist output.

fix(core): fix lint errors from new dist output location

a35a586

Add dist/ to eslint ignore patterns since the new outDir puts compiled output inside packages/nx/dist/. Also add module boundary eslint-disable for jest-resolver.js which needs a relative import.

fix(core): use correct extension for plugin-worker based on runtime

aac76c9

When running from TS source (tests), use plugin-worker.ts. When running from compiled dist (production), use plugin-worker.js.

nx-cloud bot reviewed Mar 20, 2026

View reviewed changes

fix(core): update workspace-plugin dependencies for lint

3c419a8

Add missing dependencies (conformance, glob, js-yaml, semver, shiki) and remove unused @nx/eslint.

nx-cloud bot reviewed Mar 20, 2026

View reviewed changes

chore(core): remove workspace-plugin tsconfig

aa747a3

Co-authored-by: Coly010 <Coly010@users.noreply.github.com>

nx-cloud bot reviewed Mar 20, 2026

View reviewed changes

AgentEnder approved these changes Mar 20, 2026

View reviewed changes

FrozenPandaz approved these changes Mar 20, 2026

View reviewed changes

This was referenced Mar 21, 2026

chore(devkit): build devkit to local dist and use nodenext #34946

Draft

fix(core): add bin wrapper scripts for workspace-linked nx resolution #34959

Closed

fix(core): add explicit exports entry for nx/src/native directory #34967

Merged

Conversation

Coly010 commented Jan 15, 2026 • edited by FrozenPandaz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Behavior

Expected Behavior

Key changes:

Related Issue(s)

Uh oh!

vercel bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Deploy Preview for nx-docs failed. Why did it fail? →

Uh oh!

nx-cloud bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

nx-cloud bot left a comment

Choose a reason for hiding this comment

Nx Cloud is proposing a fix for your failed CI:

Uh oh!

nx-cloud bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Nx Cloud is proposing a fix for your failed CI:

Uh oh!

nx-cloud bot left a comment

Choose a reason for hiding this comment

Nx Cloud is proposing a fix for your failed CI:

Uh oh!

nx-cloud bot left a comment

Choose a reason for hiding this comment

Nx Cloud is proposing a fix for your failed CI:

Uh oh!

nx-cloud bot left a comment

Choose a reason for hiding this comment

✅ The fix from Nx Cloud was applied automatically

Uh oh!

github-actions bot commented Mar 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Coly010 commented Jan 15, 2026 •

edited by FrozenPandaz

Loading

vercel bot commented Jan 15, 2026 •

edited

Loading

netlify bot commented Jan 15, 2026 •

edited

Loading

nx-cloud bot commented Jan 15, 2026 •

edited

Loading

nx-cloud bot left a comment •

edited

Loading