consumer: make query nsqlookupd timeouts configurable#211
Closed
guyannanfei25 wants to merge 2 commits intonsqio:masterfrom
Closed
consumer: make query nsqlookupd timeouts configurable#211guyannanfei25 wants to merge 2 commits intonsqio:masterfrom
guyannanfei25 wants to merge 2 commits intonsqio:masterfrom
Conversation
Member
|
I think this is a good change, thanks for the contribution! However, I don't think we should lean on the existing Can we add new |
Author
|
I think |
Member
|
My thinking is that if we're going to improve this, might as well do it completely and in an obvious way. |
Member
|
replaced by #360 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when network is not well, 2 seconds may not be able dail success.
Use nsq.Config.DialTimeout to configure this parameter