fix: remove appending of descriptions from different markers#56
Merged
lander2k2 merged 3 commits intonukleros:mainfrom Sep 23, 2022
Merged
fix: remove appending of descriptions from different markers#56lander2k2 merged 3 commits intonukleros:mainfrom
lander2k2 merged 3 commits intonukleros:mainfrom
Conversation
If there are more than two instances of an identical marker with a description, an error will be returned because the descriptions are being appended to one another. So identical markers throw an error indicating they are different if there are > 2 instances of the identical marker. This fix removes the append. Signed-off-by: Rich Lander <lander2k2@protonmail.com>
Previously, the descriptions array was being checked if nil. However, the array of strings is never nil. It's either an empty array or it has string values in the array. Therefore, the descriptions were never added. Signed-off-by: Rich Lander <lander2k2@protonmail.com>
Signed-off-by: Rich Lander <lander2k2@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there are more than two instances of an identical marker with a description, an error will be returned because the descriptions are being appended to one another. So identical markers throw an error indicating they are different if there are > 2 instances of the identical marker. This fix removes the append.
Signed-off-by: Rich Lander lander2k2@protonmail.com