feat: replace QtIOCompressor with KArchive#82
Conversation
streams/streamspage.cpp
Outdated
| { | ||
| QString fileName = QFileDialog::getOpenFileName(this, tr("Import Streams"), QDir::homePath(), | ||
| tr("XML Streams (*.xml *.xml.gz *.cantata)")); | ||
| tr("XML Streams (*.xml *.xml *.cantata)")); |
There was a problem hiding this comment.
It looks like this translation is broken. Probably needs to just be "XML Streams (*.xml *.cantata)" (though, what is a .cantata file?)
There was a problem hiding this comment.
Yes, the intent was *.xml... I didn't touch *.cantata because I wasn't sure but agree, it probably isn't valid. Worse case it's some legacy thing that is no longer used.
translations/blank.ts
Outdated
| <message> | ||
| <location filename="../streams/streamspage.cpp" line="207"/> | ||
| <source>XML Streams (*.xml *.xml.gz *.cantata)</source> | ||
| <source>XML Streams (*.xml * *.cantata)</source> |
There was a problem hiding this comment.
The *.xml.gz was an oversight on my part... I was just getting rid of the .gz extensions and missed the fact there was already *.xml there, so it is indeed a duplicate. I'm thinking that the *.cantata must be some kind of legacy thing, I looked and don't see it mentioned anywhere else, so safe to delete also I believe.
translations/blank.ts
Outdated
| <message> | ||
| <location filename="../streams/streamspage.cpp" line="218"/> | ||
| <source>XML Streams (*.xml.gz)</source> | ||
| <source>XML Streams (*)</source> |
There was a problem hiding this comment.
That was a miss, I had intended it to be:
|
ok, let me take a look. so you have done p0, p1 and now you're on p2. |
| compressor.setStreamFormat(QtIOCompressor::GzipFormat); | ||
| if (compressor.open(QIODevice::ReadOnly)) { | ||
| data = compressor.readAll(); | ||
| if (f.open(QIODevice::ReadOnly)) { |
There was a problem hiding this comment.
if we are going to add KF6Archive as a dependency, why completely get rid of compression here? we might as well avoid spoiling existing caches
plus, it seems KCompressionDevice's interface is pretty similar to use, so I think I will spend some time to adjust these changes to use KCompressionDevice as well
|
My impression from looking at it was that the existing working services don't use or don't need. Where do you believe it would be useful or make a difference. |
nullobsi
force-pushed
the
cantata-p2-drop-qtio
branch
from
c6084df to
b2ceacf
Compare
It has been deprecated with 6.10. Unfortunately endFilterChange() is only available since that version.
Add option BUNDLED_KARCHIVE to determine whether this is used.
Where QTIOCompressor was used, it is replaced with KCompressionDevice.
nullobsi
force-pushed
the
cantata-p2-drop-qtio
branch
from
0784a39 to
9ee0414
Compare
nullobsi
changed the title
3 participants
This patch completes the transition away from QtIOCompressor by removing all remaining references and cleanup logic. It follows P1, which replaced bundled usage with the system library.
Changes: