Replace deprecated "filter" by "where" in registry.nu#119
Merged
cptpiepmatz merged 1 commit intonushell:mainfrom Jun 12, 2025
Merged
Replace deprecated "filter" by "where" in registry.nu#119cptpiepmatz merged 1 commit intonushell:mainfrom
cptpiepmatz merged 1 commit intonushell:mainfrom
Conversation
Member
|
Yeah, that should be it, thanks! |
Member
|
Oh, the CI runs on an old version of nu |
nushell deprecated filter in favour of where. Should be drop in replacement.
Contributor
Author
|
Noob question, is it safe to drop my branch? |
|
yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nushell deprecated filter in favour of where.
Should be drop in replacement.
Description
After recent update a nushell message:
I think in the relevant file nupm already uses a closure to hold the condition, so as far as I can tell no further changes should be required.
Sorry if the PR is lackin in something I'm doing this mid work and I'm very green at this (first PR actually).