revert: internal commands with spaces#184
Merged
fdncred merged 1 commit intonushell:mainfrom Feb 22, 2025
Merged
Conversation
Contributor
Author
|
One way to address the highlighting would be the semantic tokens of lsp, I think it's not very difficult to implement. And IMO it's definitely a better solution for highlighting, as it will also handle user defined commands. |
Contributor
|
100% agree about semantic tokens. I'm happy to revert this when you're ready. Not sure if you want to wait for max to chime in on the other thread or just pull the trigger. Let me know. |
Contributor
Author
|
@fdncred I think it's safe to merge now. The semantic tokens feature might take a while to implement, a little bit tight on my schedule recently. |
Contributor
|
Thanks. Looking forward to seeing (1) how we handle commands with spaces and (2) semantic tokens in the future. |
fdncred
pushed a commit
to nushell/nushell
that referenced
this pull request
Feb 25, 2025
…aces (#15173) # Description We decided to move that specific highlighting task from tree-sitter-nu to lsp for various reasons. nushell/tree-sitter-nu#184 # User-Facing Changes Before: <img width="404" alt="image" src="https://github.com/user-attachments/assets/79fad167-e424-4411-8aa2-334f08ecc4ab" /> After: <img width="404" alt="image" src="https://github.com/user-attachments/assets/8eec7c6c-2f63-4a7d-9e98-9e0c397be6bf" /> # Tests + Formatting +1 # After Submitting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case we might want to revert #161 as discussed