refactor: unquoted_pattern_repeat & flag_equals_value#189
Merged
fdncred merged 4 commits intonushell:mainfrom Mar 1, 2025
Merged
refactor: unquoted_pattern_repeat & flag_equals_value#189fdncred merged 4 commits intonushell:mainfrom
fdncred merged 4 commits intonushell:mainfrom
Conversation
Contributor
|
Thanks. I'll post timing in the tracking issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#185
The case statement count in
ts_lexreduced from 4040 to 3290, while the total state count doesn't change much.Time to verify the statement that wasm compilation time is mainly determined by
ts_lexcase count.Sadly,
tree-sitter build -wkeeps pulling the docker image of wrong arch on my arm64 machine.Have to rely on your test number, @fdncred.
One more failing case compared to previous ver:
But I checked
nu_scripts, seems nobody actually writes crazy stuff like that