Skip to content

refactor: unquoted_pattern_repeat & flag_equals_value#189

Merged
fdncred merged 4 commits intonushell:mainfrom
blindFS:optim
Mar 1, 2025
Merged

refactor: unquoted_pattern_repeat & flag_equals_value#189
fdncred merged 4 commits intonushell:mainfrom
blindFS:optim

Conversation

@blindFS
Copy link
Contributor

@blindFS blindFS commented Mar 1, 2025

#185

16:#define STATE_COUNT 6432
17:#define LARGE_STATE_COUNT 1254

The case statement count in ts_lex reduced from 4040 to 3290, while the total state count doesn't change much.
Time to verify the statement that wasm compilation time is mainly determined by ts_lex case count.

Sadly, tree-sitter build -w keeps pulling the docker image of wrong arch on my arm64 machine.
Have to rely on your test number, @fdncred.

One more failing case compared to previous ver:

echo e>foo
echo err>>foo

But I checked nu_scripts, seems nobody actually writes crazy stuff like that

@fdncred fdncred merged commit b99dc3b into nushell:main Mar 1, 2025
3 checks passed
@fdncred
Copy link
Contributor

fdncred commented Mar 1, 2025

Thanks. I'll post timing in the tracking issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants