Skip to content

fix: id in collection_type should allow hyphen#192

Merged
fdncred merged 1 commit intonushell:mainfrom
blindFS:collection_type
Mar 10, 2025
Merged

fix: id in collection_type should allow hyphen#192
fdncred merged 1 commit intonushell:mainfrom
blindFS:collection_type

Conversation

@blindFS
Copy link
Contributor

@blindFS blindFS commented Mar 10, 2025

Fixes parsing error in this:

let x: record<foo-bar: string> = { foo-bar: 'tree-sitter' }

@fdncred
Copy link
Contributor

fdncred commented Mar 10, 2025

conflicts now, probably due to landing your other pr.

@blindFS
Copy link
Contributor Author

blindFS commented Mar 10, 2025

conflicts now, probably due to landing your other pr.

Yeah, easy to cause conflict with parser.c in the repo.

@fdncred fdncred merged commit c38dae7 into nushell:main Mar 10, 2025
3 checks passed
@fdncred
Copy link
Contributor

fdncred commented Mar 10, 2025

Thanks

@blindFS
Copy link
Contributor Author

blindFS commented Mar 10, 2025

@fdncred I wonder why hyphen is banned in variable names?

image

to distinguish from 1 - 1?

@blindFS blindFS deleted the collection_type branch March 10, 2025 12:03
@fdncred
Copy link
Contributor

fdncred commented Mar 10, 2025

to distinguish from 1 - 1?

ya, i believe that's it. sorry, i forgot about that. also, i forget where but there is some mechanism that automatically changes a-b into a_b. I thought it was custom commands or custom command parameters but those aren't allowed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants