fix: id in collection_type should allow hyphen#192
Merged
fdncred merged 1 commit intonushell:mainfrom Mar 10, 2025
Merged
Conversation
Contributor
|
conflicts now, probably due to landing your other pr. |
ac48cfa to
d27fbad
Compare
Contributor
Author
Yeah, easy to cause conflict with parser.c in the repo. |
Contributor
|
Thanks |
Contributor
Author
|
@fdncred I wonder why hyphen is banned in variable names?
to distinguish from |
Contributor
ya, i believe that's it. sorry, i forgot about that. also, i forget where but there is some mechanism that automatically changes a-b into a_b. I thought it was custom commands or custom command parameters but those aren't allowed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes parsing error in this: