feat: allow new type of bare word string interpolation#212
Closed
blindFS wants to merge 2 commits intonushell:mainfrom
Closed
feat: allow new type of bare word string interpolation#212blindFS wants to merge 2 commits intonushell:mainfrom
blindFS wants to merge 2 commits intonushell:mainfrom
Conversation
Member
|
I think this is one of the syntax constructs that we don't really need tree-sitter to parse. IMO scripts/modules should always prefer the explicit string interpolation syntax. |
Contributor
Author
|
That makes sense, yet users may not follow the best practice. |
blindFS
force-pushed
the
unquoted_with_expr
branch
from
e7d8430 to
64de06a
Compare
Contributor
Author
|
Optimized a little bit, WASM comp time: 3m40 -> 5m40. |
Contributor
|
ready to land? |
Contributor
Author
Not so sure, there's not much room for new fancy syntaxes. |
Contributor
Author
|
Sorry I got the number wrong, 5min40 was from previous commit. With |
Contributor
|
oof, 15min would probably break zed. darn. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While fixing #199, this PR will increase case number of
ts_lsfrom 3376 to 4111. #185Not sure we want to land this.
Personally I'd like nushell to forbid all subexpressions in unquoted strings, because that's the job of
$""/$''string interpolation in the first place. But the ease/robustness of parsing it brings won't worth such a huge breaking change, probably we still need this fix in the future and find another way to reduce the compilation time.