Skip to content

feat!: add support of new custom constant completer syntax#226

Merged
fdncred merged 2 commits intonushell:mainfrom
blindFS:new_completer_syntax
Oct 6, 2025
Merged

feat!: add support of new custom constant completer syntax#226
fdncred merged 2 commits intonushell:mainfrom
blindFS:new_completer_syntax

Conversation

@blindFS
Copy link
Contributor

@blindFS blindFS commented Oct 6, 2025

nushell/nushell#16789

A breaking change since param_cmd is now renamed as param_completer.

@blindFS
Copy link
Contributor Author

blindFS commented Oct 6, 2025

CC @Bahex

@blindFS blindFS marked this pull request as ready for review October 6, 2025 08:45
Copy link
Member

@Bahex Bahex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blindFS wow thanks for the quick update (after I added yet more syntax 😔)

I got confused about val_record in param_completer at first, then I saw the test case.

def test [
  x: int@[1 2],
  y: string@{f: [a b]}.f,
  --zero(-z): list<string@$var.cell?>
= [a b],
] {}

Looks good to me!

@fdncred fdncred merged commit e1509fc into nushell:main Oct 6, 2025
4 checks passed
@fdncred
Copy link
Contributor

fdncred commented Oct 6, 2025

Thanks

@blindFS blindFS deleted the new_completer_syntax branch October 6, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants