feat: add general attribute support#215
Open
miswanting wants to merge 1 commit intonuxt-modules:mainfrom
Open
Conversation
✅ Live Preview ready!
|
✅ Deploy Preview for nuxt-color-mode ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
danielroe
reviewed
Nov 15, 2023
Collaborator
danielroe
left a comment
danielroe
left a comment
There was a problem hiding this comment.
Would it be possible to merge with dataValue so we don't duplicate the runtime code? Perhaps we leave just the attrName code, and normalise attrName -> data-${dataValue}?
Author
|
You mean: keep these two options, but merge them into one implement code, in order to reduce the code duplicate? If so, I`ll try. And here's another thing I need your recommend: Is it okay to name such option as |
Contributor
|
@miswanting I think it would be nice to discuss with the TDesign team as the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some UI libraries (such as TDesign) use a
theme-modeattribute on HTML tags to control dark mode, which cannot be implemented by the existingdataValueoption, so a new option namedattrNameis added, with control logic similar to that of 'dataValue'.Also fixed missing 'dataValue' in the sample code.