fix: delete_line mapping should use delete_line_file_current#277
Open
aplus01 wants to merge 1 commit intonvim-pack:masterfrom
Open
fix: delete_line mapping should use delete_line_file_current#277aplus01 wants to merge 1 commit intonvim-pack:masterfrom
aplus01 wants to merge 1 commit intonvim-pack:masterfrom
Conversation
The <leader>rd mapping was calling run_delete_line() which defaults to deleting ALL entries when called without arguments. This caused the mapping to delete lines in all files instead of just the current line. Changed to use delete_line_file_current() which correctly gets the current entry and passes it to run_delete_line().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
<leader>rdmapping callsrun_delete_line()which defaults to all entries, deleting lines in all files instead of just the current one.delete_line_file_current()already exists and does the right thing - it gets the current entry and passes it torun_delete_line().