Auth support for NVM_AUTH_HEADER env var#3380
Merged
ljharb merged 3 commits intonvm-sh:masterfrom Jul 26, 2024
Merged
Conversation
dwelch2344
changed the title
ljharb
reviewed
Jun 21, 2024
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
Looks good! It'll need some tests ofc.
ljharb
reviewed
Jun 26, 2024
ljharb
reviewed
Jun 27, 2024
ljharb
requested changes
Jun 29, 2024
ljharb
added
installing node
ljharb
force-pushed
the
auth_header
branch
2 times, most recently
from
2bf3f9a to
78e9f45
Compare
ljharb
force-pushed
the
auth_header
branch
5 times, most recently
from
016af9d to
8fcd4ab
Compare
ljharb
force-pushed
the
auth_header
branch
2 times, most recently
from
981d19c to
29331ff
Compare
Closes nvm-sh#3366 Co-authored-by: David Welch <david@davidwelch.co> Co-authored-by: Andre Kradolfer <narfdre@gmail.com>
|
Has this been tested for basic authentication using I'm trying to use NVM_AUTH_HEADER to authenticate to a proxy repo in Nexus and Nexus does not use a bearer token. |
Member
|
I'd love to get a PR with a test case for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple POC to build from, but wanted to open for feedback on #3366