[patch] Fix issue where zsh global aliases break nvm help#3394
Merged
ljharb merged 1 commit intonvm-sh:masterfrom Jul 26, 2024
AllySummers:fix-nvm-color-args
Merged
[patch] Fix issue where zsh global aliases break nvm help#3394ljharb merged 1 commit intonvm-sh:masterfrom AllySummers:fix-nvm-color-args
ljharb merged 1 commit intonvm-sh:masterfrom
AllySummers:fix-nvm-color-args
Conversation
Fix issue with the color codes in the nvm help text where zsh global aliases would display an inline error in the nvm help text.
Member
|
this is a fine change, but to be clear it's not "short" aliases, it's only zsh's global aliases which do this (and are a very bad idea as a result). |
ljharb
added
shell: zsh
shell alias clobbering
ljharb
approved these changes
Jul 26, 2024
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
This is fine, but it'd be really nice to have a zsh-only regression test to check for this.
Contributor
Author
|
I'll see if I can do that maybe over the weekend or early to mid next week! If I have forgotten, you're welcome to ping me. Thanks for the quick review! |
Member
|
@AllySummers i'm going to merge this shortly, and I would really appreciate a follow-up PR to add a test for zsh global aliases :-) |
ljharb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue with the color codes in the nvm help text where short shell aliases would display an inline error in the nvm help text.
Given a zsh alias such as:
This would cause an issue with the
nvm --helptext, where the colour code function would have an unquoted 'C' and therefore print an error to the console and silently continue. I have attached a screenshot of what it looks like with this update and what it looks like before