Skip to content

Add NWNX_Player_ReloadTlk()#1739

Merged
mtijanic merged 1 commit intonwnxee:masterfrom
julien-lecomte:tlk-reload
Mar 10, 2024
Merged

Add NWNX_Player_ReloadTlk()#1739
mtijanic merged 1 commit intonwnxee:masterfrom
julien-lecomte:tlk-reload

Conversation

@julien-lecomte
Copy link
Copy Markdown
Contributor

In case you want the less capable, but also less dangerous thing ;-)

Tested with 2 tlks: faerun_en.tlk and faerun_fr.tlk. Both served with nwsync.

Changed from "en" to "fr" via these two lines:

NWNX_Player_SetResManOverride(oSpeaker, RESTYPE_TLK, "faerun_en", "faerun_fr");
NWNX_Player_ReloadTlk(oSpeaker);

@julien-lecomte
Copy link
Copy Markdown
Contributor Author

Hadn't noticed that this PR embarked other modifications that were not meant to be here.

@julien-lecomte
Copy link
Copy Markdown
Contributor Author

To continue on the conversation we had on discord: is this "good enough"? Or do you plan on doing a more complicated version with better features?

For my usage, it's all that I need. The only issue I could regret is not being able to set the tlk before chargen (for new feats or classes for example)

@Daztek
Copy link
Copy Markdown
Member

Daztek commented Mar 9, 2024

You could probably write a tweak that sends the tlk resource override + tlk reload before chargen

@julien-lecomte
Copy link
Copy Markdown
Contributor Author

I can look into this.

@mtijanic
Copy link
Copy Markdown
Member

Eh, let's just merge this anyway. Worst case, it'll get moved to deprecated as a wrapper of something else later. Or, removed and replaced with the tweak. But I think it's fine as is.

Please resolve the changelog conflict and I'll merge.

@julien-lecomte
Copy link
Copy Markdown
Contributor Author

OK. I've rebased the branch on top of master.

@mtijanic mtijanic merged commit 2186dc2 into nwnxee:master Mar 10, 2024
@julien-lecomte julien-lecomte deleted the tlk-reload branch March 10, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants