Create a new store plugin#1743
Merged
Daztek merged 2 commits intonwnxee:masterfrom Mar 5, 2024
julien-lecomte:stores
Merged
Conversation
Daztek
reviewed
Mar 5, 2024
Comment on lines
+76
to
+77
| ASSERT_OR_THROW(nValue >= 1); | ||
| ASSERT_OR_THROW(nValue <= 1000); |
Member
There was a problem hiding this comment.
Why are the asserts >=1 and <= 1000 here while for the others it's >=0 and <=100, that said, are they percentages or flat goldpiece values?
Contributor
Author
There was a problem hiding this comment.
The values are the min and max that the toolset editor allows us to use in the UI. They're percentage points: 110 is 10% increase in price.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New NWScript Functions
GetIsRestrictedBuyItem{Get|Set}BlackMarketMarkDown{Get|Set}MarkDown{Get|Set}MarkUpSince there's the possibilty of having a whitelist or blacklist for selling back to the store, I'm unsure if exposing just
GetIsRestrictedBuyItemis sufficient.