Skip to content

Tweaks: add NWNX_TWEAKS_CAN_USE_ITEMS_WHILE_POLYMORPHED#1780

Merged
Daztek merged 1 commit intonwnxee:masterfrom
hendrikgit:tweak-item-use-while-poly
Oct 22, 2024
Merged

Tweaks: add NWNX_TWEAKS_CAN_USE_ITEMS_WHILE_POLYMORPHED#1780
Daztek merged 1 commit intonwnxee:masterfrom
hendrikgit:tweak-item-use-while-poly

Conversation

@hendrikgit
Copy link
Copy Markdown
Contributor

I'm not sure about the Hooks::Order

@Daztek
Copy link
Copy Markdown
Member

Daztek commented Oct 13, 2024

Hooks::Order::Early should be ok.

Here's what I usually follow, but it can be fuzzy

The rule for ordering should be roughly:
Earliest for pure event notification hooks
Early for skippable events, or events that modify state in before/after
Late for things that provide alternative implementation in some cases, like the POS getters in creature
Latest for things that almost never call the original
Final for things that fully reimplement base game functions

@hendrikgit hendrikgit force-pushed the tweak-item-use-while-poly branch from 8e2cf5a to 62ba8a8 Compare October 14, 2024 20:17
@hendrikgit
Copy link
Copy Markdown
Contributor Author

Changed to Hooks::Order::Early.

@Daztek Daztek merged commit c176945 into nwnxee:master Oct 22, 2024
@hendrikgit hendrikgit deleted the tweak-item-use-while-poly branch May 16, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants