MaxLevel: GetSpellsKnownPerLevelHook rewrite#1819
Merged
Daztek merged 1 commit intonwnxee:masterfrom Feb 13, 2025
Merged
Conversation
Daztek
reviewed
Feb 12, 2025
Member
Daztek
left a comment
Daztek
left a comment
There was a problem hiding this comment.
I don't use this plugin so I'll trust you it works! Also a changelog entry would be nice
hendrikgit
force-pushed
the
maxlevel-spellsknown-fix
branch
from
72b1111 to
d0da626
Compare
hendrikgit
force-pushed
the
maxlevel-spellsknown-fix
branch
from
d0da626 to
0faf051
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue with Bards not having their cantrips when getting them on a class level other than 1 due to low charisma attribute. Other problems with the previous implementation might have existed but this is the one that I noticed.
@Daztek I found the [[maybe_unused]] attribute after a short Google search and don't know if it is appropriate here.