Skip to content

Fix errors when renaming NZB during download, avoid 0-byte file and improve hardlink cleanup#768

Merged
dnzbk merged 2 commits intodevelopfrom
fix/nzb-rename
Mar 30, 2026
Merged

Fix errors when renaming NZB during download, avoid 0-byte file and improve hardlink cleanup#768
dnzbk merged 2 commits intodevelopfrom
fix/nzb-rename

Conversation

@dnzbk
Copy link
Copy Markdown
Collaborator

@dnzbk dnzbk commented Mar 26, 2026

Description

  • Skips file completion for 0-byte/empty files (0 successful articles)
  • Fixes "No such file or directory" errors when renaming an ongoing NZB download by checking if files exist before moving them
  • Automatically removes intermediate hardlink directories
  • Persists hardlink path in DiskState (bump queue version to 63)

Testing

  • macOS Tahoe,
  • Windows 7,10

@dnzbk dnzbk requested a review from luckedea March 26, 2026 11:09
@dnzbk dnzbk marked this pull request as draft March 26, 2026 11:10
@dnzbk dnzbk changed the title Fix errors when renaming NZB during download, avoid 0-byte file and i… Fix errors when renaming NZB during download, avoid 0-byte file and improve hardlink cleanup Mar 27, 2026
@dnzbk dnzbk marked this pull request as ready for review March 27, 2026 09:32
@dnzbk dnzbk force-pushed the fix/nzb-rename branch 2 times, most recently from bafdc8f to 9a30207 Compare March 27, 2026 15:00
@dnzbk dnzbk merged commit 488e50d into develop Mar 30, 2026
201 of 254 checks passed
@dnzbk dnzbk deleted the fix/nzb-rename branch March 30, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0-byte file created if article download fails in CompleteFileParts renaming an ongoing download leads to needless par repair

2 participants