Conversation
This driver can render oak to the android screen, but size events and scaling of content / scaling of touch events is not complete.
This: - fixes size of the rendered output to scale to the target screen appropriately - fixes touch to click event conversion - removes unused code - removes paint looping completely, driving paints from window.Scale
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
==========================================
+ Coverage 92.60% 92.67% +0.07%
==========================================
Files 141 141
Lines 6406 6406
==========================================
+ Hits 5932 5937 +5
+ Misses 415 407 -8
- Partials 59 62 +3
Continue to review full report at Codecov.
|
|
After this is merged, we should open an issue that gomobile init requires a c compiler (although I don't know if we can do anything about it realistically, historically we still make this an issue) I'll also open an issue that our driver does not respect when the android phone changes orientation. |
| size: size, | ||
| img: s.images.NewImage(size.X, size.Y), | ||
| } | ||
| s.activeImages = append(s.activeImages, img) |
There was a problem hiding this comment.
Question we can have simultaneous access to this do we care enough to put a lock around it? Or given that the only other accessor is at lifecycle cross event (cleanup) we just dont care.
There was a problem hiding this comment.
To put our discussion in writing: we decided it's not important; we both want to rewrite the shiny driver interface anyway and don't expect this interface to be used by anyone but oak.
Implausiblyfun
left a comment
Implausiblyfun
left a comment
There was a problem hiding this comment.
Looks great other than that one potential end of cycle conflict. Tested and it was nice how easy it was to get a build out to a device. I will see how cleanly the env variables can be pulled into a mage buid for the test-template.
3 participants
I think we should merge this in after we add instructions for how to set this up, then cut a release with it + windows arm