scene: Embed Eventhandler to allow for some embedded calls#197
Merged
200sc merged 2 commits intofeature/v4-eventsfrom Mar 28, 2022
Merged
scene: Embed Eventhandler to allow for some embedded calls#197200sc merged 2 commits intofeature/v4-eventsfrom
200sc merged 2 commits intofeature/v4-eventsfrom
Conversation
Contributor
|
If we rename |
Contributor
Author
|
Ah nice I guess I didnt dig deep enough on it. |
200sc
approved these changes
Mar 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sold on this but its the only shortening of methods that seems even slightly reasonable. Unfortunately creating helper functions around the context with it still working on the generic functions doesnt work and the embedded interface doesnt allow for this to be passwed as an eventhandler to binds. So definitely not ideal and we refer to it as ctx.Handler rather than ctx.EventHandler which while shorter seems less descriptive.
The bonus of course is signature for callermap interactions so one can call things like ctx.Register(entity)
Thoughts?