event/internal: Unbind calls now take the current reset of the bus#208
Merged
event/internal: Unbind calls now take the current reset of the bus#208
Conversation
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
=======================================
Coverage 94.98% 94.98%
=======================================
Files 143 143
Lines 6344 6344
=======================================
Hits 6026 6026
Misses 287 287
Partials 31 31
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Contributor
|
Will merge once all the runners have finished their tests and cut v4.0.1 |
200sc
approved these changes
Jun 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When returning unbindthisbind we previously did not take into account the bus reset count.
Now we will succesfully remove the bind as long as the bus has not already been reset between the unbind call and unbind's go channel's resolution.