Merged
Conversation
e1f11cf to
536f5af
Compare
536f5af to
746a641
Compare
7b94b2d to
296b961
Compare
rube-de
reviewed
Oct 25, 2024
|
This PR should be now merged in the vue branch. |
11c2ae8 to
3b27751
Compare
Contributor
This would break, current React rewrite, as it is based on "v1". Can we hold off merging? Until rewrite of frontend is done on top of this PR? cc: @matevz |
Closed
Contributor
73a3601 to
edfd962
Compare
edfd962 to
f023836
Compare
f023836 to
89aeab3
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Merge after oasisprotocol/sapphire-paratime#332 and oasisprotocol/sapphire-paratime#303
TODO: Wait for sapphire-contracts to be deployed on npmjs (oasisprotocol/sapphire-paratime#490). Then update the lock file.