rofl-8004: Initial commit and example, cleanups#5
Merged
Conversation
matevz
force-pushed
the
matevz/feature/rofl-8004-startup
branch
6 times, most recently
from
ea14bc9 to
ac631bf
Compare
matevz
force-pushed
the
matevz/feature/rofl-8004-startup
branch
2 times, most recently
from
69dc600 to
5584b21
Compare
matevz
force-pushed
the
matevz/feature/rofl-8004-startup
branch
from
5584b21 to
e584bce
Compare
matevz
changed the title
matevz
force-pushed
the
matevz/feature/rofl-8004-startup
branch
from
e584bce to
5285a0b
Compare
matevz
force-pushed
the
matevz/feature/rofl-8004-startup
branch
from
5285a0b to
494505b
Compare
ptrus
reviewed
Nov 20, 2025
Member
ptrus
left a comment
ptrus
left a comment
There was a problem hiding this comment.
Did a quick check, will try it out later! But mostly looks good to me!
| On the first startup it will register your ROFL as an ERC-8004 agent if it | ||
| doesn't exist yet and store the app ID along the agent's metadata. | ||
|
|
||
| On every startup it will derive configured public key(s) and upsert them to |
Member
There was a problem hiding this comment.
Oh it would probably be useful to add an "upsert metadata" method to the rofl appd api? Because with the current API, the containers would need to coordinate to not override each others metadata.
Member
Author
There was a problem hiding this comment.
Yes, upsert would come in handy to avoid race conditions.
matevz
force-pushed
the
matevz/feature/rofl-8004-startup
branch
3 times, most recently
from
c2fb1a6 to
a517a84
Compare
lubej
reviewed
Nov 24, 2025
matevz
force-pushed
the
matevz/feature/rofl-8004-startup
branch
5 times, most recently
from
1304ed1 to
5c4cc76
Compare
ptrus
reviewed
Nov 26, 2025
ptrus
reviewed
Nov 26, 2025
| if agent_id is None: | ||
| agent_id = metadata.get(ERC8004_AGENT_ID_KEY, None) | ||
| if agent_id is None: | ||
| name = os.getenv("AGENT_NAME") or "rofl-agent" |
Member
There was a problem hiding this comment.
In a future version we could query the rofl.App app metadata (via consensus query) and populate agent_name, desccription , version from there.
ptrus
reviewed
Nov 26, 2025
ptrus
approved these changes
Nov 26, 2025
matevz
force-pushed
the
matevz/feature/rofl-8004-startup
branch
from
5c4cc76 to
f0c01c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
IdentityRegistry