go/worker/storage/committee: Fix Stuck Storage Finalization#6239
Merged
martintomazic merged 4 commits intomasterfrom Jun 27, 2025
Merged
go/worker/storage/committee: Fix Stuck Storage Finalization#6239martintomazic merged 4 commits intomasterfrom
martintomazic merged 4 commits intomasterfrom
Conversation
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
martintomazic
force-pushed
the
martin/bugfix/storage-sync
branch
from
94bae20 to
ad1b003
Compare
martintomazic
commented
Jun 24, 2025
martintomazic
requested review from
kostko,
peterjgilbert,
peternose,
pro-wh and
ptrus
as code owners
kostko
reviewed
Jun 24, 2025
martintomazic
force-pushed
the
martin/bugfix/storage-sync
branch
2 times, most recently
from
bd73007 to
335554a
Compare
martintomazic
commented
Jun 26, 2025
Contributor
Author
martintomazic
left a comment
martintomazic
left a comment
There was a problem hiding this comment.
Did a bit of refactor as going through the code. Happy to revert if you think it does not simplify.
Not really sure how to reproduce it/how we want to test this? e2e would probably require at least maxPendingVersions of blocks to trigger this (slow?).
martintomazic
force-pushed
the
martin/bugfix/storage-sync
branch
from
335554a to
f27d35f
Compare
kostko
reviewed
Jun 26, 2025
martintomazic
force-pushed
the
martin/bugfix/storage-sync
branch
from
f27d35f to
7a589c8
Compare
kostko
reviewed
Jun 27, 2025
martintomazic
force-pushed
the
martin/bugfix/storage-sync
branch
2 times, most recently
from
b2629e7 to
d8802d7
Compare
As of go 1.22 for loop variables are created with every iteration.
Max number of non-finalized versions is now exposed as part of the nodedb api.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6239 +/- ##
==========================================
- Coverage 64.68% 64.17% -0.51%
==========================================
Files 678 678
Lines 65934 65938 +4
==========================================
- Hits 42648 42319 -329
- Misses 18388 18705 +317
- Partials 4898 4914 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
martintomazic
force-pushed
the
martin/bugfix/storage-sync
branch
from
d8802d7 to
9ea6450
Compare
kostko
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6238