Conversation
| switch (`${type}`) { | ||
| case "number": return Number; | ||
| case "string": return String; | ||
| case "boolean": return Boolean; |
There was a problem hiding this comment.
this differs from autotype in that it will not turn "false" into false. is that ok?
There was a problem hiding this comment.
Ah, no, that wasn’t intentional.
| } | ||
| switch (`${type}`) { | ||
| case "number": return Number; | ||
| case "string": return String; |
There was a problem hiding this comment.
in autoType the string gets trimmed. probably not something to include in casting, but will be different
| } | ||
|
|
||
| function NewDate(value) { | ||
| return new Date(value); |
There was a problem hiding this comment.
do we want to do the timezone workaround for Safari?
I agree that unmentioned columns be included by default
I agree, nice to explicitly drop unwanted columns (also documents the decision nicely)
I don't think so. The primary interface for this implies that auto already suggested the type for the column. I like this level of interface being explicit.
Seems like something we want to support across the platform better right?
i agree, we should standardize. if someone wants a variation the inline function is easy to use.
I don't think so.
Don't have a strong opinion, but making it as fast as possible seems a worthy goal. |
Open questions (with my inclination):