Wrap saving operations in a transaction#42
Open
ykiu wants to merge 3 commits intoocadotechnology:masterfrom
Open
Wrap saving operations in a transaction#42ykiu wants to merge 3 commits intoocadotechnology:masterfrom
ykiu wants to merge 3 commits intoocadotechnology:masterfrom
Conversation
Wrap saving operations in a transaction to prevent inconsistency between main model and closure model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation seems to break the closure tree when we try to save an instance with dirty parent value (i.e. referencing self or child). This causes db constraint failure, so I suggest we wrap the saving operation in a transaction to detect and reject dirty data.