ci(pin-artifacts.yml): Add build artifacts links within upstream commits status#501
Merged
erikmd merged 3 commits intoocaml-sf:masterfrom Nov 26, 2022
Merged
ci(pin-artifacts.yml): Add build artifacts links within upstream commits status#501erikmd merged 3 commits intoocaml-sf:masterfrom
erikmd merged 3 commits intoocaml-sf:masterfrom
Conversation
erikmd
added a commit
to AltGr/learn-ocaml
that referenced
this pull request
Dec 29, 2022
… pr/481 (to-be-rebased) * 'master' of https://github.com/ocaml-sf/learn-ocaml: fix(learnocaml_report.css): Display multiple spaces in code excerpts (ocaml-sf#503) ci(pin-artifacts.yml): Add build artifacts links within upstream commits status (ocaml-sf#501) deps(opam): Bump ssl (0.5.10 -> 0.5.12) (ocaml-sf#499) build(static-binaries): Fix building of static binaries on CI (ocaml-sf#497)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kind: enhancement
Close Feature: Improve
static-builds.ymlonpull_request(Add link to artifacts) #475Description
Make it easier for end-users to download static binaries from unmerged PRs.
Note: due to the standard permissions enforced by GitHub, the provided links require end users to be logged in github.com, and only work for 90 days.
@yurug: as this PR is not critical but very useful to address #475, and it can't be tested anew (beyond my separated test below) before the new
.ymlis part of the repo itself, I plan to merge it tonight; but feel free to comment meanwhile anyway, if need be!Screenshots as a demo
cf. https://github.com/pfitaxel/learn-ocaml-issue475-poc :
In commit statuses
In PR checks
Checklist
Note to maintainers